Use Rubocop plugins, use Ruby 3.0 as minimum version everywhere #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numbata
reviewed
May 9, 2025
|
There's a bunch of good stuff here, want to finish it @olivier-thatch ? |
|
@dblock let's remove ruby-head from master as well and rebase this then. |
That was done, rebase. |
olivier-thatch
force-pushed
the
rubocop-clean-up
branch
3 times, most recently
from
f5360ab to
fef2334
Compare
numbata
force-pushed
the
rubocop-clean-up
branch
from
9f084a4 to
e710a8a
Compare
|
Merging now to make master green again. And we can release right after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bit of cleanup:
requireto silence a warning with recent Rubocop versionsThis is consistent with 3.0 being the minimum required version in the gemspec.